Skip to content

refactor(diff-index): reuse i to reduce size (-32b)#3193

Merged
JoviDeCroock merged 1 commit intopreactjs:masterfrom
liuarui:master
Jun 17, 2021
Merged

refactor(diff-index): reuse i to reduce size (-32b)#3193
JoviDeCroock merged 1 commit intopreactjs:masterfrom
liuarui:master

Conversation

@liuarui
Copy link
Copy Markdown
Contributor

@liuarui liuarui commented Jun 17, 2021

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 17, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +1% (-2.04ms - +1.43ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +3% (-1.55ms - +0.91ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-12.65ms - +11.27ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +2% (-0.36ms - +0.52ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +1% (-4.15ms - +1.08ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -1% - +5% (-0.35ms - +1.52ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -2% - +0% (-0.07ms - +0.01ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +2% (-0.03ms - +0.12ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master122.14ms - 124.44ms-unsure 🔍
-1% - +2%
-1.43ms - +2.04ms
preact-local121.69ms - 124.29msunsure 🔍
-2% - +1%
-2.04ms - +1.43ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.53ms - 3.54ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master47.61ms - 48.19ms-unsure 🔍
-1% - +1%
-0.69ms - +0.50ms
preact-local47.47ms - 48.51msunsure 🔍
-1% - +1%
-0.50ms - +0.69ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master81.86ms - 83.12ms-unsure 🔍
-2% - +1%
-1.55ms - +0.42ms
preact-local82.29ms - 83.82msunsure 🔍
-1% - +2%
-0.42ms - +1.55ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master76.41ms - 84.20ms-unsure 🔍
-8% - +5%
-6.98ms - +4.01ms
preact-local77.91ms - 85.67msunsure 🔍
-5% - +9%
-4.01ms - +6.98ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master51.98ms - 58.28ms-unsure 🔍
-6% - +10%
-3.18ms - +5.48ms
preact-local51.01ms - 56.95msunsure 🔍
-10% - +6%
-5.48ms - +3.18ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master79.19ms - 81.81ms-unsure 🔍
-1% - +3%
-1.14ms - +2.35ms
preact-local78.73ms - 81.06msunsure 🔍
-3% - +1%
-2.35ms - +1.14ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master47.33ms - 49.47ms-unsure 🔍
-3% - +4%
-1.22ms - +1.94ms
preact-local46.88ms - 49.20msunsure 🔍
-4% - +3%
-1.94ms - +1.22ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.75ms - 31.59ms-unsure 🔍
-3% - +5%
-0.91ms - +1.55ms
preact-local29.53ms - 31.16msunsure 🔍
-5% - +3%
-1.55ms - +0.91ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.59ms - 3.60ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.59ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1449.86ms - 1467.25ms-unsure 🔍
-1% - +1%
-11.27ms - +12.65ms
preact-local1449.65ms - 1466.08msunsure 🔍
-1% - +1%
-12.65ms - +11.27ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.37ms - 25.37ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.37ms - 25.37msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master22.20ms - 22.76ms-unsure 🔍
-2% - +2%
-0.52ms - +0.36ms
preact-local22.23ms - 22.90msunsure 🔍
-2% - +2%
-0.36ms - +0.52ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.59ms - 1.59ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.59ms - 1.59msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master122.36ms - 126.29ms-unsure 🔍
-1% - +3%
-1.08ms - +4.15ms
preact-local121.07ms - 124.51msunsure 🔍
-3% - +1%
-4.15ms - +1.08ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.15ms - 6.26ms-unsure 🔍
-2% - +0%
-0.12ms - +0.03ms
preact-local6.20ms - 6.31msunsure 🔍
-0% - +2%
-0.03ms - +0.12ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.33ms - 31.57ms-unsure 🔍
-5% - +1%
-1.52ms - +0.35ms
preact-local30.84ms - 32.24msunsure 🔍
-1% - +5%
-0.35ms - +1.52ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.65ms - 4.65ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.65ms - 4.65msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.88ms - 2.94ms-unsure 🔍
-0% - +2%
-0.01ms - +0.07ms
preact-local2.85ms - 2.91msunsure 🔍
-2% - +0%
-0.07ms - +0.01ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 17, 2021

Coverage Status

Coverage remained the same at 99.622% when pulling 3392e05 on liuarui:master into 1f89e50 on preactjs:master.

@liuarui liuarui changed the title refactor(diff-index): reuse i to reduce size refactor(diff-index): reuse i to reduce size (-2b) Jun 17, 2021
@liuarui liuarui changed the title refactor(diff-index): reuse i to reduce size (-2b) refactor(diff-index): reuse i to reduce size (-32b) Jun 17, 2021
@liuarui
Copy link
Copy Markdown
Contributor Author

liuarui commented Jun 17, 2021 •
edited
Loading

-32b
🤣

JoviDeCroock
JoviDeCroock approved these changes Jun 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome find!

@JoviDeCroock JoviDeCroock merged commit 840095d into preactjs:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuarui @coveralls @JoviDeCroock