Improve typing of forwardRef#3144
Merged
JoviDeCroock merged 2 commits intopreactjs:masterfrom May 11, 2021
Merged
Conversation
The specified ref type is now included in the typing of the functional component returned by `forwardRef`.
|
Heads up that this change was a breaking change for me. I had to override this locally with -): preact.FunctionalComponent<Omit<P, 'ref'> & { ref?: preact.RefObject<R> }>;
+): preact.FunctionalComponent<Omit<P, 'ref'> & { ref?: preact.Ref<R> }>; |
Contributor
Author
|
Yeah, sorry, there's PR #3214 with a fix. |
|
Cool, thanks! Also note that you don't need const fn = <P = {}>(p: P & {ref?: number}) => console.log(p.ref);
// Won't compile
// fn({
// ref: 'foo',
// });
fn({
ref: 1,
});
fn({});This caused some problems in my codebase, so I replaced it with: +): preact.FunctionalComponent<Omit<P, 'ref'> & { ref?: preact.Ref<R> }>;
-): preact.FunctionalComponent<P & { ref?: preact.Ref<R> }>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specified ref type is now included in the typing of the functional component returned by
forwardRef.This is similar to the corresponding React typings, which currently look like this: