Skip to content

Simplify diffChildren's handling of excessDomChildren and oldDom#2941

Merged
marvinhagemeister merged 5 commits intomasterfrom
simplify-diffChildren-oldDom
Jan 19, 2021
Merged

Simplify diffChildren's handling of excessDomChildren and oldDom#2941
marvinhagemeister merged 5 commits intomasterfrom
simplify-diffChildren-oldDom

Conversation

@andrewiggins
Copy link
Copy Markdown
Member

@andrewiggins andrewiggins commented Jan 18, 2021

  • Move excess dom children cleanup to diffElementNodes
  • Remove EMPTY_OBJ hack in diffChildren
  • Remove unused excessDomChildren check in placeChild

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 18, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +0% (-1.09ms - +0.65ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -6% - +2% (-1.80ms - +0.50ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +2% (-8.57ms - +23.54ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +1% (-0.63ms - +0.32ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +1% (-0.63ms - +1.12ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -6% - +8% (-1.86ms - +2.73ms)
    preact-local vs preact-master
  • text_update: faster ✔ 3% - 8% (0.13ms - 0.32ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - -0% (-0.01ms - -0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - -0% (-0.01ms - -0.01ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #744

  • Commit: e6cd08d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master153.16ms - 154.38ms-unsure 🔍
-0% - +1%
-0.65ms - +1.09ms
preact-local152.93ms - 154.16msunsure 🔍
-1% - +0%
-1.09ms - +0.65ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.61ms-unsure 🔍
+0% - +0%
+0.01ms - +0.01ms
preact-local3.59ms - 3.59msunsure 🔍
-0% - -0%
-0.01ms - -0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master55.31ms - 56.13ms-unsure 🔍
-6% - +1%
-3.62ms - +0.62ms
preact-local55.14ms - 59.30msunsure 🔍
-1% - +6%
-0.62ms - +3.62ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master88.40ms - 89.11ms-unsure 🔍
-1% - +1%
-0.59ms - +1.11ms
preact-local87.73ms - 89.28msunsure 🔍
-1% - +1%
-1.11ms - +0.59ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master101.81ms - 102.76ms-slower ❌
0% - 2%
0.03ms - 2.34ms
preact-local100.05ms - 102.16msfaster ✔
0% - 2%
0.03ms - 2.34ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master55.98ms - 56.44ms-faster ✔
1% - 3%
0.45ms - 1.97ms
preact-local56.69ms - 58.14msslower ❌
1% - 4%
0.45ms - 1.97ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master110.07ms - 111.73ms-unsure 🔍
-1% - +1%
-1.58ms - +1.17ms
preact-local110.01ms - 112.20msunsure 🔍
-1% - +1%
-1.17ms - +1.58ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master55.96ms - 56.57ms-unsure 🔍
-1% - +1%
-0.48ms - +0.46ms
preact-local55.91ms - 56.64msunsure 🔍
-1% - +1%
-0.46ms - +0.48ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 130
  • Built by: CI #744

  • Commit: e6cd08d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.62ms - 31.24ms-unsure 🔍
-2% - +6%
-0.50ms - +1.80ms
preact-local28.97ms - 30.59msunsure 🔍
-6% - +2%
-1.80ms - +0.50ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-local3.51ms - 3.52msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #744

  • Commit: e6cd08d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1296.59ms - 1318.72ms-unsure 🔍
-2% - +1%
-23.54ms - +8.57ms
preact-local1303.50ms - 1326.78msunsure 🔍
-1% - +2%
-8.57ms - +23.54ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local25.98ms - 25.99msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #744

  • Commit: e6cd08d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.79ms - 30.43ms-unsure 🔍
-1% - +2%
-0.32ms - +0.63ms
preact-local29.60ms - 30.30msunsure 🔍
-2% - +1%
-0.63ms - +0.32ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #744

  • Commit: e6cd08d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master132.11ms - 133.73ms-unsure 🔍
-1% - +0%
-1.12ms - +0.63ms
preact-local132.84ms - 133.49msunsure 🔍
-0% - +1%
-0.63ms - +1.12ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.19ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-local6.19ms - 6.19msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #744

  • Commit: e6cd08d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.52ms - 34.67ms-unsure 🔍
-8% - +5%
-2.73ms - +1.86ms
preact-local31.86ms - 35.19msunsure 🔍
-6% - +8%
-1.86ms - +2.73ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
+0% - +0%
+0.01ms - +0.01ms
preact-local4.84ms - 4.84msunsure 🔍
-0% - -0%
-0.01ms - -0.01ms		-
text_update
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 250
  • Built by: CI #744

  • Commit: e6cd08d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.70ms - 3.85ms-slower ❌
4% - 9%
0.13ms - 0.32ms
preact-local3.49ms - 3.62msfaster ✔
3% - 8%
0.13ms - 0.32ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 18, 2021 •
edited
Loading

Size Change: -100 B (0%)

Total Size: 42 kB

Filename Size Change
dist/preact.js 3.96 kB -29 B (0%)
dist/preact.min.js 3.98 kB -25 B (0%)
dist/preact.module.js 3.99 kB -26 B (0%)
dist/preact.umd.js 4.03 kB -20 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.45 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 186 B 0 B
devtools/dist/devtools.module.js 196 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

JoviDeCroock
JoviDeCroock approved these changes Jan 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unused import in diff/children, but good to go :D nice find

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 18, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 99.438% when pulling 759b1eb on simplify-diffChildren-oldDom into 139a862 on master.

marvinhagemeister
marvinhagemeister approved these changes Jan 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see less references of excessDomChildren 👍

@marvinhagemeister marvinhagemeister merged commit f6c44cd into master Jan 19, 2021
@marvinhagemeister marvinhagemeister deleted the simplify-diffChildren-oldDom branch January 19, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewiggins @coveralls @marvinhagemeister @JoviDeCroock