Skip to content

Remove unused comment#2909

Merged
marvinhagemeister merged 1 commit intomasterfrom
remove-dead-comment
Jan 3, 2021
Merged

Remove unused comment#2909
marvinhagemeister merged 1 commit intomasterfrom
remove-dead-comment

Conversation

@marvinhagemeister
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister commented Jan 3, 2021

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 3, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +2% (-1.35ms - +3.25ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -9% - +14% (-3.84ms - +5.67ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -2% - +1% (-40.10ms - +27.01ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -4% - +2% (-1.31ms - +0.56ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +1% (-4.44ms - +1.21ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -10% - +3% (-5.33ms - +1.69ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +1% (-0.18ms - +0.04ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #672

  • Commit: 1edc3e7

duration

VersionAvg timevs preact-mastervs preact-local
preact-master164.76ms - 168.17ms-unsure 🔍
-2% - +1%
-3.25ms - +1.35ms
preact-local165.87ms - 168.95msunsure 🔍
-1% - +2%
-1.35ms - +3.25ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.60ms - 3.61msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master63.50ms - 64.57ms-unsure 🔍
-2% - +1%
-1.00ms - +0.63ms
preact-local63.60ms - 64.84msunsure 🔍
-1% - +2%
-0.63ms - +1.00ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master99.25ms - 101.21ms-unsure 🔍
-1% - +1%
-1.30ms - +1.31ms
preact-local99.35ms - 101.08msunsure 🔍
-1% - +1%
-1.31ms - +1.30ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master112.94ms - 116.00ms-unsure 🔍
-1% - +3%
-1.21ms - +3.44ms
preact-local111.61ms - 115.11msunsure 🔍
-3% - +1%
-3.44ms - +1.21ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master61.94ms - 64.52ms-unsure 🔍
-3% - +3%
-1.71ms - +2.09ms
preact-local61.64ms - 64.44msunsure 🔍
-3% - +3%
-2.09ms - +1.71ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master115.19ms - 121.09ms-unsure 🔍
-5% - +1%
-6.40ms - +1.40ms
preact-local118.08ms - 123.19msunsure 🔍
-1% - +5%
-1.40ms - +6.40ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master60.91ms - 62.24ms-unsure 🔍
-3% - +0%
-1.86ms - +0.16ms
preact-local61.67ms - 63.18msunsure 🔍
-0% - +3%
-0.16ms - +1.86ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 120
  • Built by: CI #672

  • Commit: 1edc3e7

duration

VersionAvg timevs preact-mastervs preact-local
preact-master39.10ms - 45.42ms-unsure 🔍
-13% - +9%
-5.67ms - +3.84ms
preact-local39.62ms - 46.73msunsure 🔍
-9% - +14%
-3.84ms - +5.67ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.52ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #672

  • Commit: 1edc3e7

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1848.68ms - 1897.06ms-unsure 🔍
-1% - +2%
-27.01ms - +40.10ms
preact-local1843.07ms - 1889.58msunsure 🔍
-2% - +1%
-40.10ms - +27.01ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #672

  • Commit: 1edc3e7

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.63ms - 30.86ms-unsure 🔍
-2% - +4%
-0.56ms - +1.31ms
preact-local29.16ms - 30.58msunsure 🔍
-4% - +2%
-1.31ms - +0.56ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #672

  • Commit: 1edc3e7

duration

VersionAvg timevs preact-mastervs preact-local
preact-master158.90ms - 163.09ms-unsure 🔍
-1% - +3%
-1.21ms - +4.44ms
preact-local157.48ms - 161.28msunsure 🔍
-3% - +1%
-4.44ms - +1.21ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local6.19ms - 6.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 70
  • Built by: CI #672

  • Commit: 1edc3e7

duration

VersionAvg timevs preact-mastervs preact-local
preact-master50.30ms - 55.69ms-unsure 🔍
-3% - +11%
-1.69ms - +5.33ms
preact-local48.92ms - 53.42msunsure 🔍
-10% - +3%
-5.33ms - +1.69ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 130
  • Built by: CI #672

  • Commit: 1edc3e7

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.84ms - 4.03ms-unsure 🔍
-1% - +5%
-0.04ms - +0.18ms
preact-local3.80ms - 3.91msunsure 🔍
-5% - +1%
-0.18ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 3, 2021

Coverage Status

Coverage remained the same at 99.609% when pulling a76e0a0 on remove-dead-comment into aba653e on master.

@marvinhagemeister marvinhagemeister merged commit d29d858 into master Jan 3, 2021
@marvinhagemeister marvinhagemeister deleted the remove-dead-comment branch January 3, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marvinhagemeister @coveralls @JoviDeCroock