Skip to content

add nodeType to the render element stub#2904

Merged
JoviDeCroock merged 2 commits intomasterfrom
fix-portals
Jan 3, 2021
Merged

add nodeType to the render element stub#2904
JoviDeCroock merged 2 commits intomasterfrom
fix-portals

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Member

@JoviDeCroock JoviDeCroock commented Jan 3, 2021

Fixes #2897

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 3, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • ⏱ 02_replace1k: unsure 🔍 -2% - +1% (-2.69ms - +1.07ms)
    preact-local vs preact-master
  • ⏱ 03_update10th1k_x16: unsure 🔍 -4% - +5% (-1.34ms - +1.88ms)
    preact-local vs preact-master
  • ⏱ 07_create10k: unsure 🔍 -1% - +1% (-16.69ms - +17.43ms)
    preact-local vs preact-master
  • ⏱ filter_list: unsure 🔍 -4% - +3% (-1.20ms - +0.85ms)
    preact-local vs preact-master
  • ⏱ hydrate1k: unsure 🔍 -1% - +2% (-1.90ms - +3.16ms)
    preact-local vs preact-master
  • ⏱ many_updates: unsure 🔍 -3% - +11% (-1.06ms - +4.63ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +1% (-0.16ms - +0.05ms)
    preact-local vs preact-master

usedJSHeapSize

  • ⏱ 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • ⏱ 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • ⏱ 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • ⏱ filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • ⏱ hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.03ms)
    preact-local vs preact-master
  • ⏱ many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

⏱ 02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #656

  • Commit: d6c8d7d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master158.10ms - 160.56ms-unsure 🔍
-1% - +2%
-1.07ms - +2.69ms
preact-local157.10ms - 159.94msunsure 🔍
-2% - +1%
-2.69ms - +1.07ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.60ms - 3.61msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master61.26ms - 62.79ms-unsure 🔍
-1% - +2%
-0.71ms - +1.19ms
preact-local61.22ms - 62.35msunsure 🔍
-2% - +1%
-1.19ms - +0.71ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master95.13ms - 96.58ms-unsure 🔍
-2% - +0%
-1.62ms - +0.48ms
preact-local95.66ms - 97.18msunsure 🔍
-1% - +2%
-0.48ms - +1.62ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master108.42ms - 111.27ms-unsure 🔍
-1% - +2%
-1.46ms - +2.33ms
preact-local108.16ms - 110.66msunsure 🔍
-2% - +1%
-2.33ms - +1.46ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master58.49ms - 60.68ms-unsure 🔍
-2% - +3%
-1.22ms - +1.93ms
preact-local58.11ms - 60.35msunsure 🔍
-3% - +2%
-1.93ms - +1.22ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master111.54ms - 117.34ms-unsure 🔍
-2% - +5%
-2.66ms - +5.84ms
preact-local109.75ms - 115.96msunsure 🔍
-5% - +2%
-5.84ms - +2.66ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master58.38ms - 59.27ms-unsure 🔍
-1% - +1%
-0.69ms - +0.77ms
preact-local58.21ms - 59.37msunsure 🔍
-1% - +1%
-0.77ms - +0.69ms		-
⏱ 03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 120
  • Built by: CI #656

  • Commit: d6c8d7d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master33.04ms - 35.53ms-unsure 🔍
-5% - +4%
-1.88ms - +1.34ms
preact-local33.54ms - 35.57msunsure 🔍
-4% - +5%
-1.34ms - +1.88ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
⏱ 07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #656

  • Commit: d6c8d7d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2025.94ms - 2048.48ms-unsure 🔍
-1% - +1%
-17.43ms - +16.69ms
preact-local2024.77ms - 2050.38msunsure 🔍
-1% - +1%
-16.69ms - +17.43ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
⏱ filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #656

  • Commit: d6c8d7d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.94ms - 31.40ms-unsure 🔍
-3% - +4%
-0.85ms - +1.20ms
preact-local29.77ms - 31.22msunsure 🔍
-4% - +3%
-1.20ms - +0.85ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
⏱ hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #656

  • Commit: d6c8d7d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master132.52ms - 136.19ms-unsure 🔍
-2% - +1%
-3.16ms - +1.90ms
preact-local133.25ms - 136.73msunsure 🔍
-1% - +2%
-1.90ms - +3.16ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.19ms-unsure 🔍
-0% - +0%
-0.03ms - +0.00ms
preact-local6.19ms - 6.22msunsure 🔍
-0% - +0%
-0.00ms - +0.03ms		-
⏱ many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #656

  • Commit: d6c8d7d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master39.21ms - 43.35ms-unsure 🔍
-11% - +2%
-4.63ms - +1.06ms
preact-local41.11ms - 45.02msunsure 🔍
-3% - +11%
-1.06ms - +4.63ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 90
  • Built by: CI #659

  • Commit: f072351

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.27ms - 3.44ms-unsure 🔍
-2% - +5%
-0.05ms - +0.16ms
preact-local3.24ms - 3.36msunsure 🔍
-5% - +1%
-0.16ms - +0.05ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 3, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 99.609% when pulling 9e73ab9 on fix-portals into ef3d54c on master.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 3, 2021 •
edited
Loading

Size Change: +8 B (0%)

Total Size: 41.7 kB

Filename Size Change
compat/dist/compat.js 3.24 kB +3 B (0%)
compat/dist/compat.module.js 3.25 kB +2 B (0%)
compat/dist/compat.umd.js 3.29 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.03 kB 0 B
dist/preact.min.js 4.06 kB 0 B
dist/preact.module.js 4.05 kB 0 B
dist/preact.umd.js 4.1 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

marvinhagemeister
marvinhagemeister approved these changes Jan 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@JoviDeCroock JoviDeCroock merged commit 34fa677 into master Jan 3, 2021
@JoviDeCroock JoviDeCroock deleted the fix-portals branch January 3, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

createPortal throws for 10.5.8 in dev mode

3 participants

@JoviDeCroock @coveralls @marvinhagemeister