Fix child reordering with memo#2896
Merged
marvinhagemeister merged 1 commit intomasterfrom Jan 1, 2021
Merged
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Results02_replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
03_update10th1k_x16duration
usedJSHeapSize
07_create10kduration
usedJSHeapSize
filter_listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many_updatesduration
usedJSHeapSize
text_updateduration
usedJSHeapSize
|
andrewiggins
commented
Jan 1, 2021
| expect(scratch.innerHTML).to.equal('<div>Hello</div>'); | ||
| }); | ||
|
|
||
| it.skip('should preserve state between double nested fragment and double nested array', () => { |
Member
Author
There was a problem hiding this comment.
This test was skipped in the world where we flattened arrays. Since we now convert arrays to Fragments it passes. Went ahead and enabled it.
|
Size Change: 0 B Total Size: 41.6 kB ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Jan 1, 2021
marvinhagemeister
approved these changes
Jan 1, 2021
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
This is fantastic 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the return value of
reorderChildreninreorderChildrenso that the new value ofoldDombubbles up through the recursion. This update ensures the next iteration of the loop inside diffChildren begins with the correctoldDomvalueFixes #2895