Skip to content

Upgarde some devDeps#2856

Merged
marvinhagemeister merged 2 commits intomasterfrom
upgrade-dev-deps
Dec 1, 2020
Merged

Upgarde some devDeps#2856
marvinhagemeister merged 2 commits intomasterfrom
upgrade-dev-deps

Conversation

@andrewiggins
Copy link
Copy Markdown
Member

@andrewiggins andrewiggins commented Dec 1, 2020

Was setting up a new computer and the tests weren't running. I thought it was related to some old devDeps, but I just didn't have Chrome installed 🤦‍♂️. I had already upgraded some deps so I thought, what the heck - might as well check them in.

Packages I did not upgrade:

  • eslint, et. al. (couldn't be bothered)
  • microbundle (Don't have time to determine if this regresseses any thing)
  • prettier (likely should be its own PR)
  • typescript (Version is fixed at the min version we support)
  • webpack, karma-webpack (Nope - not dealing with this)

@andrewiggins
Upgarde some devDeps
1d8ec9d 
Was setting up a new computer and the tests weren't running. I thought it was related to some old devDeps, but I just didn't have Chrome installed 🤦‍♂️. I had already upgraded some deps so I thought, what the heck - might as well check them in.

Packages I did not upgrade:
* eslint, et. al. (couldn't be bothered)
* microbundle (Don't have time to determine if this regresses any thing)
* prettier (likely should be its own PR)
* typescript (Version is fixed at the min version we support)
* webpack, karma-webpack (Nope - not dealing with this)
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2020 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -4% - +2% (-7.11ms - +2.81ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +8% (-0.14ms - +2.70ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -9% - +6% (-4.24ms - +2.83ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +5% (-0.13ms - +0.14ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 50
  • Built by: CI #550

  • Commit: d9ff5b6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master155.52ms - 162.79ms-unsure 🔍
-2% - +5%
-2.81ms - +7.11ms
preact-local153.63ms - 160.38msunsure 🔍
-4% - +2%
-7.11ms - +2.81ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.56ms - 3.57ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.56ms - 3.57msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
03_update10th1k_x16
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 110
  • Built by: CI #550

  • Commit: d9ff5b6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master33.45ms - 35.44ms-unsure 🔍
-7% - +0%
-2.70ms - +0.14ms
preact-local34.72ms - 36.74msunsure 🔍
-0% - +8%
-0.14ms - +2.70ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.50ms - 3.51ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.51ms - 3.51msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
many_updates
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 80
  • Built by: CI #550

  • Commit: d9ff5b6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master43.97ms - 48.84ms-unsure 🔍
-6% - +9%
-2.83ms - +4.24ms
preact-local43.14ms - 48.26msunsure 🔍
-9% - +6%
-4.24ms - +2.83ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 80
  • Built by: CI #550

  • Commit: d9ff5b6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.94ms - 3.11ms-unsure 🔍
-5% - +4%
-0.14ms - +0.13ms
preact-local2.93ms - 3.14msunsure 🔍
-4% - +5%
-0.13ms - +0.14ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.82ms - 0.82msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 1, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c503b9e on upgrade-dev-deps into 6bceb44 on master.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 41.9 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.23 kB 0 B
compat/dist/compat.module.js 3.23 kB 0 B
compat/dist/compat.umd.js 3.28 kB 0 B
debug/dist/debug.js 3.12 kB 0 B
debug/dist/debug.module.js 3.11 kB 0 B
debug/dist/debug.umd.js 3.21 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.04 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 4149a85 into master Dec 1, 2020
@marvinhagemeister marvinhagemeister deleted the upgrade-dev-deps branch December 1, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewiggins @coveralls @marvinhagemeister @JoviDeCroock