Skip to content

Fix ref not being removed from props with jsx-runtime#2840

Merged
marvinhagemeister merged 3 commits intomasterfrom
jsx-runtime
Nov 21, 2020
Merged

Fix ref not being removed from props with jsx-runtime#2840
marvinhagemeister merged 3 commits intomasterfrom
jsx-runtime

Conversation

@marvinhagemeister
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister commented Nov 21, 2020

Fixes #2839

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 21, 2020 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +2% (-1.24ms - +3.13ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +4% (-1.27ms - +1.15ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -8% - +5% (-4.46ms - +2.94ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +5% (-0.12ms - +0.15ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: slower ❌ 0% - 0% (0.00ms - 0.00ms)
    preact-local vs preact-master
  • text_update: slower ❌ 0% - 0% (0.00ms - 0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 50
  • Built by: CI #514

  • Commit: 39c2aa1

duration

VersionAvg timevs preact-mastervs preact-local
preact-master148.40ms - 150.79ms-unsure 🔍
-2% - +1%
-3.13ms - +1.24ms
preact-local148.71ms - 152.37msunsure 🔍
-1% - +2%
-1.24ms - +3.13ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.57ms - 3.58ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.57ms - 3.57msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
03_update10th1k_x16
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 70
  • Built by: CI #514

  • Commit: 39c2aa1

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.46ms - 32.04ms-unsure 🔍
-4% - +4%
-1.15ms - +1.27ms
preact-local30.28ms - 32.10msunsure 🔍
-4% - +4%
-1.27ms - +1.15ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.51ms - 3.52ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.51ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
many_updates
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 70
  • Built by: CI #514

  • Commit: 39c2aa1

duration

VersionAvg timevs preact-mastervs preact-local
preact-master50.69ms - 56.14ms-unsure 🔍
-6% - +9%
-2.94ms - +4.46ms
preact-local50.15ms - 55.16msunsure 🔍
-8% - +5%
-4.46ms - +2.94ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-faster ✔
0% - 0%
0.00ms - 0.00ms
preact-local4.85ms - 4.85msslower ❌
0% - 0%
0.00ms - 0.00ms		-
text_update
  • Browser: chrome-headless 86.0.4240.198
  • Sample size: 110
  • Built by: CI #514

  • Commit: 39c2aa1

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.00ms - 3.22ms-unsure 🔍
-5% - +4%
-0.15ms - +0.12ms
preact-local3.04ms - 3.21msunsure 🔍
-4% - +5%
-0.12ms - +0.15ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-faster ✔
0% - 0%
0.00ms - 0.00ms
preact-local0.82ms - 0.82msslower ❌
0% - 0%
0.00ms - 0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 21, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling fc22df2 on jsx-runtime into 94d6fc4 on master.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 21, 2020 •
edited
Loading

Size Change: +88 B (0%)

Total Size: 41.9 kB

Filename Size Change
jsx-runtime/dist/jsxRuntime.js 327 B +29 B (8%) 🔍
jsx-runtime/dist/jsxRuntime.module.js 335 B +29 B (8%) 🔍
jsx-runtime/dist/jsxRuntime.umd.js 405 B +30 B (7%) 🔍
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.19 kB 0 B
compat/dist/compat.module.js 3.21 kB 0 B
compat/dist/compat.umd.js 3.25 kB 0 B
debug/dist/debug.js 3.12 kB 0 B
debug/dist/debug.module.js 3.11 kB 0 B
debug/dist/debug.umd.js 3.21 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit c024345 into master Nov 21, 2020
@marvinhagemeister marvinhagemeister deleted the jsx-runtime branch November 21, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New JSX runtime includes ref attributes in the DOM

3 participants

@marvinhagemeister @coveralls @JoviDeCroock