Move child reodering to diffChildren#2813
Merged
marvinhagemeister merged 14 commits intomasterfrom Nov 21, 2020
Merged
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
window.usedJSHeapSize
Results02_replace1kduration
window.usedJSHeapSize
03_update10th1k_x16duration
window.usedJSHeapSize
many_updatesduration
window.usedJSHeapSize
text_updateduration
window.usedJSHeapSize
|
|
Size Change: -17 B (0%) Total Size: 41.8 kB
ℹ️ View Unchanged
|
JoviDeCroock
commented
Nov 2, 2020
123b355 to
bf2e9d9
Compare
JoviDeCroock
commented
Nov 15, 2020
| vnode._parent = childVNode; | ||
|
|
||
| if (typeof vnode.type == 'function') { | ||
| reorderChildren(vnode, oldDom, parentDom); |
Member
Author
There was a problem hiding this comment.
We'd need to find a way to tell whether or not we have to traverse further:
const Cell = () => (
<Fragment>
<div>x</div>
<Fragment><div>y</div></Fragment>
</Fragment>
)
When this Cell bails we need to ensure we move y as well as x when this is moved from the top. Before this change we would forget about y within diffChildren but move it from diff.shouldComponentUpdate = false.
JoviDeCroock
commented
Nov 15, 2020
JoviDeCroock
commented
Nov 18, 2020
| ); | ||
| if ( | ||
| typeof childVNode.type == 'function' && | ||
| childVNode._children === oldVNode._children |
Member
Author
There was a problem hiding this comment.
This signals that we bailed out either due to strict equality or SCU false
marvinhagemeister
approved these changes
Nov 21, 2020
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
This looks really great! In the longterm I think we have to go with moving the placing of children into diffChildren either way 👍
Does this change catch a new bugs where we'd need a test for or is it mostly byte savings?
Member
Author
|
@marvinhagemeister mainly savings and readability |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to reorder within the scope of a single bailed vnode diff, we're in a better position when we are currently inside of a
diffChildrento correctly hand offoldDomto the next node.