Skip to content

Fix classname descriptors on Element vnodes#2786

Merged
marvinhagemeister merged 2 commits intomasterfrom
fix-classname-descriptors-elements
Oct 4, 2020
Merged

Fix classname descriptors on Element vnodes#2786
marvinhagemeister merged 2 commits intomasterfrom
fix-classname-descriptors-elements

Conversation

@developit
Copy link
Copy Markdown
Member

@developit developit commented Oct 4, 2020

This addresses my concern from #2782. I've added a test that illustrates where it matters (and grouped the className tests).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2020 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +1% (-3.72ms - +1.68ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +2% (-1.63ms - +0.66ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +2% (-2.33ms - +0.95ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +5% (-0.14ms - +0.15ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #382

  • Commit: 3a6624c

duration

VersionAvg timevs preact-mastervs preact-local
preact-master160.22ms - 163.69ms-unsure 🔍
-1% - +2%
-1.68ms - +3.72ms
preact-local158.86ms - 163.01msunsure 🔍
-2% - +1%
-3.72ms - +1.68ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.59ms - 3.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.59ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
03_update10th1k_x16
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 120
  • Built by: CI #382

  • Commit: 3a6624c

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.54ms - 31.09ms-unsure 🔍
-2% - +6%
-0.66ms - +1.63ms
preact-local28.99ms - 30.67msunsure 🔍
-5% - +2%
-1.63ms - +0.66ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.54ms - 3.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.54ms - 3.55msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 70
  • Built by: CI #382

  • Commit: 3a6624c

duration

VersionAvg timevs preact-mastervs preact-local
preact-master42.01ms - 44.45ms-unsure 🔍
-2% - +5%
-0.95ms - +2.33ms
preact-local41.44ms - 43.64msunsure 🔍
-5% - +2%
-2.33ms - +0.95ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.87ms - 4.87ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.87ms - 4.87msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 60
  • Built by: CI #382

  • Commit: 3a6624c

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.11ms - 3.23ms-unsure 🔍
-5% - +5%
-0.15ms - +0.14ms
preact-local3.04ms - 3.31msunsure 🔍
-5% - +5%
-0.14ms - +0.15ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.85ms - 0.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.85ms - 0.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2020

Size Change: -3 B (0%)

Total Size: 41.5 kB

Filename Size Change
compat/dist/compat.js 3.16 kB -2 B (0%)
compat/dist/compat.module.js 3.17 kB -1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.umd.js 3.21 kB 0 B
debug/dist/debug.js 3.09 kB 0 B
debug/dist/debug.module.js 3.09 kB 0 B
debug/dist/debug.umd.js 3.18 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 194 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.1 kB 0 B
hooks/dist/hooks.module.js 1.11 kB 0 B
hooks/dist/hooks.umd.js 1.18 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 305 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 373 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 4, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling e786577 on fix-classname-descriptors-elements into 784733c on master.

marvinhagemeister
marvinhagemeister approved these changes Oct 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Love the additional tests and hardened existing ones 👍

@marvinhagemeister marvinhagemeister merged commit 7746eaa into master Oct 4, 2020
@marvinhagemeister marvinhagemeister deleted the fix-classname-descriptors-elements branch October 4, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@developit @coveralls @marvinhagemeister @JoviDeCroock