Skip to content

Emit error event for errors handled by an error boundary#2784

Merged
marvinhagemeister merged 5 commits intomasterfrom
feature/emit-error-event-for-catched-errors
Oct 5, 2020
Merged

Emit error event for errors handled by an error boundary#2784
marvinhagemeister merged 5 commits intomasterfrom
feature/emit-error-event-for-catched-errors

Conversation

@sventschui
Copy link
Copy Markdown
Member

@sventschui sventschui commented Oct 4, 2020

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2020 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +1% (-4.62ms - +0.76ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +5% (-1.23ms - +1.65ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -1% - +9% (-0.31ms - +2.88ms)
    preact-local vs preact-master
  • text_update: slower ❌ 0% - 3% (0.00ms - 0.09ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #387

  • Commit: 0d493d2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master131.73ms - 135.81ms-unsure 🔍
-1% - +4%
-0.76ms - +4.62ms
preact-local130.09ms - 133.60msunsure 🔍
-3% - +1%
-4.62ms - +0.76ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.59ms - 3.59ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.59ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
03_update10th1k_x16
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 60
  • Built by: CI #387

  • Commit: 0d493d2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master32.44ms - 34.29ms-unsure 🔍
-5% - +4%
-1.65ms - +1.23ms
preact-local32.47ms - 34.68msunsure 🔍
-4% - +5%
-1.23ms - +1.65ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.53ms - 3.54ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.53ms - 3.54msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
many_updates
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 80
  • Built by: CI #387

  • Commit: 0d493d2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.81ms - 33.60ms-unsure 🔍
-8% - +1%
-2.88ms - +0.31ms
preact-local32.67ms - 35.32msunsure 🔍
-1% - +9%
-0.31ms - +2.88ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.87ms - 4.87ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.87ms - 4.87msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #387

  • Commit: 0d493d2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.05ms - 3.10ms-faster ✔
0% - 3%
0.00ms - 0.09ms
preact-local3.08ms - 3.15msslower ❌
0% - 3%
0.00ms - 0.09ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.85ms - 0.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.85ms - 0.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2020 •
edited
Loading

Size Change: +75 B (0%)

Total Size: 41.6 kB

Filename Size Change
debug/dist/debug.js 3.12 kB +26 B (0%)
debug/dist/debug.module.js 3.11 kB +24 B (0%)
debug/dist/debug.umd.js 3.21 kB +25 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.16 kB 0 B
compat/dist/compat.module.js 3.17 kB 0 B
compat/dist/compat.umd.js 3.21 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 194 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.1 kB 0 B
hooks/dist/hooks.module.js 1.11 kB 0 B
hooks/dist/hooks.umd.js 1.18 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 305 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 373 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

JoviDeCroock
JoviDeCroock approved these changes Oct 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

marvinhagemeister
marvinhagemeister approved these changes Oct 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome find! 🙌

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 4, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 059b5be on feature/emit-error-event-for-catched-errors into 7746eaa on master.

developit
developit reviewed Oct 4, 2020
View reviewed changes
Comment thread debug/src/debug.js Outdated
@sventschui sventschui force-pushed the feature/emit-error-event-for-catched-errors branch from 85c7523 to 1f3cc96 Compare October 4, 2020 20:30
@sventschui sventschui requested a review from developit October 4, 2020 21:04
marvinhagemeister
marvinhagemeister reviewed Oct 4, 2020
View reviewed changes
Comment thread debug/src/debug.js Outdated
developit
developit approved these changes Oct 4, 2020
View reviewed changes
Comment thread debug/src/debug.js Outdated
Comment thread debug/src/debug.js Outdated
@marvinhagemeister marvinhagemeister merged commit 100868b into master Oct 5, 2020
@marvinhagemeister marvinhagemeister deleted the feature/emit-error-event-for-catched-errors branch October 5, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit developit approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sventschui @coveralls @developit @marvinhagemeister @JoviDeCroock