Skip to content

Replace custom script with check-export-map#2777

Merged
marvinhagemeister merged 1 commit intomasterfrom
check-export-map
Sep 27, 2020
Merged

Replace custom script with check-export-map#2777
marvinhagemeister merged 1 commit intomasterfrom
check-export-map

Conversation

@marvinhagemeister
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister commented Sep 26, 2020

Made a re-usable cli binary out of it to make it easier to reuse this for our other repos. See https://github.com/marvinhagemeister/check-export-map

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 26, 2020 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -0% - +3% (-0.54ms - +5.92ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +1% (-1.47ms - +0.30ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +4% (-1.91ms - +1.62ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -2% - +3% (-0.06ms - +0.08ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #363

  • Commit: 73ad892

duration

VersionAvg timevs preact-mastervs preact-local
preact-master196.05ms - 200.21ms-unsure 🔍
-3% - +0%
-5.92ms - +0.54ms
preact-local198.35ms - 203.29msunsure 🔍
-0% - +3%
-0.54ms - +5.92ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.60ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
03_update10th1k_x16
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 120
  • Built by: CI #363

  • Commit: 73ad892

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.93ms - 32.11ms-unsure 🔍
-1% - +5%
-0.30ms - +1.47ms
preact-local30.28ms - 31.59msunsure 🔍
-5% - +1%
-1.47ms - +0.30ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.54ms - 3.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.54ms - 3.55msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 70
  • Built by: CI #363

  • Commit: 73ad892

duration

VersionAvg timevs preact-mastervs preact-local
preact-master38.45ms - 41.03ms-unsure 🔍
-4% - +5%
-1.62ms - +1.91ms
preact-local38.39ms - 40.81msunsure 🔍
-5% - +4%
-1.91ms - +1.62ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.87ms - 4.87ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.87ms - 4.87msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 85.0.4183.102
  • Sample size: 50
  • Built by: CI #363

  • Commit: 73ad892

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.65ms - 2.75ms-unsure 🔍
-3% - +2%
-0.08ms - +0.06ms
preact-local2.66ms - 2.76msunsure 🔍
-2% - +3%
-0.06ms - +0.08ms		-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.85ms - 0.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.85ms - 0.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 26, 2020

Size Change: 0 B

Total Size: 41.5 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.17 kB 0 B
compat/dist/compat.module.js 3.18 kB 0 B
compat/dist/compat.umd.js 3.23 kB 0 B
debug/dist/debug.js 3.09 kB 0 B
debug/dist/debug.module.js 3.09 kB 0 B
debug/dist/debug.umd.js 3.18 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 194 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.1 kB 0 B
hooks/dist/hooks.module.js 1.12 kB 0 B
hooks/dist/hooks.umd.js 1.18 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 305 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 373 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 26, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 74cf0df on check-export-map into 59d2f63 on master.

@marvinhagemeister marvinhagemeister merged commit 27eca03 into master Sep 27, 2020
@marvinhagemeister marvinhagemeister deleted the check-export-map branch September 27, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewiggins andrewiggins andrewiggins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marvinhagemeister @coveralls @andrewiggins