Fix capturing and non-capturing listeners on the same element#2740
Merged
JoviDeCroock merged 1 commit intopreactjs:masterfrom Sep 9, 2020
Merged
Fix capturing and non-capturing listeners on the same element#2740JoviDeCroock merged 1 commit intopreactjs:masterfrom
JoviDeCroock merged 1 commit intopreactjs:masterfrom
Conversation
JoviDeCroock
approved these changes
Sep 9, 2020
Member
JoviDeCroock
left a comment
There was a problem hiding this comment.
Looks good to me, thank you so much for this PR! Also a great added test 💯
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2739.
Open to suggestions on making it smaller/better. Not too happy with having two event proxy functions, but didn't think of a better way so far.