preact/debug: Add component stack to prop type validation error, do not pass ref to prop-types validation (fixes mui incompatbility)#2685
Merged
sventschui merged 6 commits intomasterfrom Aug 7, 2020
Conversation
|
Size Change: +165 B (0%) Total Size: 40.5 kB
ℹ️ View Unchanged
|
marvinhagemeister
previously approved these changes
Aug 7, 2020
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
Love this! We're only missing the _forwarded property in mangle.json and then it's ready to go 🙌 🚀
marvinhagemeister
approved these changes
Aug 7, 2020
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
Sweet, thank you so much for the PR 🙌 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the component stack to the prop types validation error message to help debug #2682
Not sure that inline arrow function is the best solution but I guess it is preferable over
.bind(null, vnode)