avoid touching dom-attributes during hydration#2679
Merged
JoviDeCroock merged 2 commits intomasterfrom Aug 4, 2020
Merged
Conversation
|
Size Change: +13 B (0%) Total Size: 40.3 kB
ℹ️ View Unchanged
|
developit
approved these changes
Aug 4, 2020
developit
reviewed
Aug 4, 2020
| // To fix it we make sure to reset the inferred value, so that our own | ||
| // value check in `diff()` won't be skipped. | ||
| if (newParentVNode.type == 'option') { | ||
| if (newParentVNode.type == 'option' && !isHydrating) { |
Member
There was a problem hiding this comment.
I think reversing the conditions here so the isHydrating check comes first will reduce the size to ~0. Terser will minify it to something like:
if (isHydrating) {}
else if (...) {}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2678
I broke this in https://github.com/preactjs/preact/pull/2551/files#diff-a04f8653407a342eac2cd2ea6a5c3ff6R186
render-to-stringalready sets these values correctly and we shouldn't double touch it