fix case where textarea doesn't reset state#2615
Merged
marvinhagemeister merged 5 commits intomasterfrom Jul 11, 2020
Merged
Conversation
|
Size Change: -36 B (0%) Total Size: 40 kB
ℹ️ View Unchanged
|
Member
|
Note that we don't use jsdom in our tests. They typically run in a chrome instance via karma. But it could be that the bug doesn't manifest in Chrome as easily as it may in other browsers. |
developit
reviewed
Jul 10, 2020
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
Closed
marvinhagemeister
approved these changes
Jul 11, 2020
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
Awesome! Learned something new about text area behaviour 🙌💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2604
The test doesn't reproduce this yet I think it's related to uncontrolled/controlled which isn't emulated correctly in jsdom, I tried it out in demo and this fixes the issue.