Skip to content

Add missing LICENSE files and fix submodule names#2611

Merged
marvinhagemeister merged 4 commits intopreactjs:masterfrom
hbroer:master
Jul 11, 2020
Merged

Add missing LICENSE files and fix submodule names#2611
marvinhagemeister merged 4 commits intopreactjs:masterfrom
hbroer:master

Conversation

@hbroer
Copy link
Copy Markdown

@hbroer hbroer commented Jul 9, 2020

Subpackage Names

  • renamed "preact-detools" to "preact-devtools"
  • renamed "hooks" to "preact-hooks"

License Files

  • added license files to all submodules with a package.json and a license property set (all are MIT)

The reason for this are tools like webpack-license-plugin which extracts license informations from packages. Because there where no license files inside that submodule directory roots, the licenseText property was always null for this submodules. This is fixed with a dedicated file for each subpackage.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 9, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 99.798% when pulling 90c19b5 on hbroer:master into 6562d4f on preactjs:master.

marvinhagemeister
marvinhagemeister approved these changes Jul 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for the PR 🙌 💯

@marvinhagemeister marvinhagemeister merged commit 186f9b4 into preactjs:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbroer @coveralls @marvinhagemeister