(fix) - passing null to forwardRef#2600
Merged
marvinhagemeister merged 4 commits intomasterfrom Jul 6, 2020
Merged
Conversation
|
Size Change: +6 B (0%) Total Size: 40.1 kB
ℹ️ View Unchanged
|
e86b5f7 to
35822e0
Compare
35822e0 to
59a827a
Compare
59a827a to
0e8c2a3
Compare
marvinhagemeister
approved these changes
Jul 6, 2020
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
Love this! 🙌 The test via a direct function call to copy what mobx is doing internally is very elegant 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2599