Skip to content

Prevent Suspense from inadvertently modifying shared Component class#2594

Merged
marvinhagemeister merged 2 commits intomasterfrom
fix-suspense-unsafe-methods
Jun 30, 2020
Merged

Prevent Suspense from inadvertently modifying shared Component class#2594
marvinhagemeister merged 2 commits intomasterfrom
fix-suspense-unsafe-methods

Conversation

@andrewiggins
Copy link
Copy Markdown
Member

Fixes #2525

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 29, 2020

Size Change: +2 B (0%)

Total Size: 40 kB

Filename Size Change
compat/dist/compat.module.js 3.23 kB +1 B
compat/dist/compat.umd.js 3.25 kB +1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.2 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 184 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 3.96 kB 0 B
dist/preact.min.js 3.98 kB 0 B
dist/preact.module.js 3.97 kB 0 B
dist/preact.umd.js 4.01 kB 0 B
hooks/dist/hooks.js 1.09 kB 0 B
hooks/dist/hooks.module.js 1.11 kB 0 B
hooks/dist/hooks.umd.js 1.17 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great catch! 🙌

@marvinhagemeister marvinhagemeister merged commit 87c8dd4 into master Jun 30, 2020
@marvinhagemeister marvinhagemeister deleted the fix-suspense-unsafe-methods branch June 30, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Suspense will cause UNSAFE_* method not patched properly when using preact/compat

3 participants