Add TypeScript for extending JSX types with custom elements#2581
Merged
marvinhagemeister merged 5 commits intomasterfrom Jun 14, 2020
Merged
Add TypeScript for extending JSX types with custom elements#2581marvinhagemeister merged 5 commits intomasterfrom
marvinhagemeister merged 5 commits intomasterfrom
Conversation
...to better match how our TS users will import preact JS and TS types
|
Size Change: 0 B Total Size: 39.7 kB ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Jun 14, 2020
hbroer
reviewed
Jun 16, 2020
hbroer
left a comment
There was a problem hiding this comment.
It looks like it does its job. I tried the types inside of one of our project and it seems to work as expected.
import {UiIntrinsicElements} from "@private/view-components";
declare module "preact" {
namespace createElement.JSX {
interface IntrinsicElements extends UiIntrinsicElements<HTMLAttributes> {}
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new custom element TypeScript test that validates it is possible to extend Preact's JSX types with custom elements.
This PR also locks our TypeScript to 3.5.3. I've done this to ensure that future updates we make to our types are backwards compatible with our current min TS version. If we want to take advantage of a bugfix or feature in a future version of TS, we should bump this to the new min version of TypeScript and mention the new min version in the release notes for the next Preact release.
Resolves #1180