Handle setState in render#2565
Merged
JoviDeCroock merged 1 commit intopreactjs:masterfrom Jun 2, 2020
Merged
Conversation
Member
|
Hey is it possible to reproduce this in a test? If so let's add it to prevent us from regressing in this area |
Member
|
Awesome thank you so much for the PR 👍 Let's add a test case for this like @JoviDeCroock suggested and than it's ready to be merged 🎉 |
JoviDeCroock
approved these changes
Jun 2, 2020
Member
|
Awesome work, thank you so much! |
Contributor
Author
|
Sorry, I've been busy the past few days. Hope the test I added is okay 😃 Thanks for the help! |
19cc385 to
715efe2
Compare
Contributor
Author
|
Rebased master and squashed commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2553