fix useEffect regression by using invokeCleanup in unmount#2542
Merged
marvinhagemeister merged 1 commit intopreactjs:masterfrom May 18, 2020
Merged
Conversation
JoviDeCroock
approved these changes
May 18, 2020
Member
JoviDeCroock
left a comment
There was a problem hiding this comment.
Looks good to me! Also good that we reuse that variable, I missed that my bad 😅
marvinhagemeister
approved these changes
May 18, 2020
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
Good catch! We'll publish a patch release shortly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression caused by #2494
The unmount hook cleanup wasn't using
invokeCleanupso it was relying on non functions never being assigned to_cleanupin the first place.In my project upgrading to
10.4.2caused auseEffectlike this to crash:Perhaps not a recommended usage since the typescript types would disallow it.. but still.
The promise ends up as the
_cleanupand it is of course truthy causing the component to crash when unmounted.I wrote a quick test to validate this, but not sure if I did in the best way 🤔 advice would be appreciated there.