Skip to content

polyfill prototype setter in debug#2514

Merged
JoviDeCroock merged 2 commits intomasterfrom
polyfill-proto-setter
May 2, 2020
Merged

polyfill prototype setter in debug#2514
JoviDeCroock merged 2 commits intomasterfrom
polyfill-proto-setter

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Member

Fixes #2512

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2020

Size Change: -12 B (0%)

Total Size: 39.4 kB

Filename Size Change
debug/dist/debug.js 2.99 kB -5 B (0%)
debug/dist/debug.module.js 2.98 kB -4 B (0%)
debug/dist/debug.umd.js 3.08 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.13 kB 0 B
compat/dist/compat.module.js 3.15 kB 0 B
compat/dist/compat.umd.js 3.18 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 194 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 3.86 kB 0 B
dist/preact.min.js 3.86 kB 0 B
dist/preact.module.js 3.88 kB 0 B
dist/preact.umd.js 3.91 kB 0 B
hooks/dist/hooks.js 1.09 kB 0 B
hooks/dist/hooks.module.js 1.11 kB 0 B
hooks/dist/hooks.umd.js 1.17 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

Comment thread debug/src/debug.js Outdated

const isWeakMapSupported = typeof WeakMap == 'function';

Object.setPrototypeOf =
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be safer to ponyfill this?

@JoviDeCroock JoviDeCroock requested a review from developit May 2, 2020 15:34
Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet✌️

@JoviDeCroock JoviDeCroock merged commit 2744ac4 into master May 2, 2020
@JoviDeCroock JoviDeCroock deleted the polyfill-proto-setter branch May 2, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

render fails in iOS 7 Safari - TypeError: 'undefined' is not a function (evaluating 'Object.setPrototypeOf(n,b)')

3 participants