Update focus tests to better match user behavior#2506
Merged
marvinhagemeister merged 2 commits intomasterfrom Apr 27, 2020
Merged
Update focus tests to better match user behavior#2506marvinhagemeister merged 2 commits intomasterfrom
marvinhagemeister merged 2 commits intomasterfrom
Conversation
|
Size Change: 0 B Total Size: 39.3 kB ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Apr 27, 2020
marvinhagemeister
approved these changes
Apr 27, 2020
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
That's awesome! Much cleaner 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually, component's just don't appear out of nowhere. Most common cases are toggles (
condition && <Component />) or lists (<div><br/>{children}<br/></div>). As such, I've updated our focus tests to better match this common behavior.Further, our test cases now more closely match #2446. I've also added @JoviDeCroock's test case from #2482 using this new
DynamicListhelper class I've added.Let me know what you think!