Add update benchmark from js-framework-benchmark#2489
Merged
andrewiggins merged 1 commit intomasterfrom Apr 21, 2020
Merged
Conversation
This implementation doesn't slowdown the CPU by 16x like js-framework-benchmark but I assume the bench is still useful/meaningful
andrewiggins
commented
Apr 20, 2020
| return promise; | ||
| } | ||
|
|
||
| export function getRowIdSel(index) { |
Member
Author
There was a problem hiding this comment.
I put these getRowIdSel and getRowLinkSel functions in the util file cuz if we add more benches from js-framework-benchmark, they'll be used by multiple benches
|
Size Change: 0 B Total Size: 39.3 kB ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Apr 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation doesn't slowdown the CPU by 16x like js-framework-benchmark but I assume the bench is still useful/meaningful