Reduce number of builds in actions#2476
Merged
marvinhagemeister merged 1 commit intomasterfrom Apr 17, 2020
Merged
Conversation
|
Size Change: 0 B Total Size: 39.2 kB ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new
preparescript, our current actions setup builds Preact 4 times:Build Job:
npm ciwhich builds as part of thepreparescriptnpm run buildTest Job:
npm ciwhich builds as part of thepreparescriptnpm testwhich runsnpm run buildSince this is redundant I've removed the
npm run buildstep from the build jobs. However I left the extra build in test for now. I thought this might still be useful to support the development scenario where you make local changes and then runnpm testto validate them. Ifnpm testdoesn't do a build, then developers need to update their habits to also do a build before runningnpm test, or elsenpm testwill test the previous build without their changes.Let me know what you think!