Add npm prepare script#2473
Merged
marvinhagemeister merged 6 commits intomasterfrom Apr 16, 2020
Merged
Conversation
|
Size Change: 0 B Total Size: 39.2 kB ℹ️ View Unchanged
|
Member
Author
|
@JoviDeCroock I forgot about #2451. Do you think you could pull out that copy script into a separate PR so I can build on it here? (I'm using |
Member
|
I thought we discussed not using |
Member
Author
|
@ForsakenHarmony Yea, that's right. I forgot about our discussion related to #2451 😅 - replacing it with Jovi's script now |
a4b34bc to
ea5f08b
Compare
JoviDeCroock
approved these changes
Apr 15, 2020
Member
JoviDeCroock
left a comment
There was a problem hiding this comment.
That script looks really good 😄 hehe great work Andre!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
preparescripts all Preact to be installed directly from github. In order for this to work on Windows I needed to replace the Linux onlycpcommand with a cross platform alternative. I just went withcpy-clifrom sindresorhus. Open to other suggestions.