Update act type signature#2444
Merged
JoviDeCroock merged 1 commit intopreactjs:masterfrom Apr 8, 2020
Merged
Conversation
Contributor
|
Looks good. Should anything be added to the typescript tests for this? (there doesn't seem to be much so far so maybe the answer is no) |
JoviDeCroock
approved these changes
Apr 7, 2020
Contributor
Author
Sounds like a good idea! |
act sync and async always returns a promise, also allow for promise generating callback
00cf76d to
92ecdb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What am I trying to achieve?
Resolves #2441
Updating
act's typings1- Callback return type can still be function or explicitly, return a promise (if async ideally)
2- Return type to be
Promise<void>What approach did I use?
🔍 Digging Preact's code base to learn
📚 Mostly following Preact's contribution guidelines: