Fallback to render when subtrees are inserted on hydration#2438
Merged
JoviDeCroock merged 2 commits intomasterfrom Apr 3, 2020
Merged
Fallback to render when subtrees are inserted on hydration#2438JoviDeCroock merged 2 commits intomasterfrom
JoviDeCroock merged 2 commits intomasterfrom
Conversation
…ffing props again
|
Size Change: +13 B (0%) Total Size: 38.7 kB
ℹ️ View Unchanged
|
JoviDeCroock
commented
Apr 3, 2020
| } | ||
|
|
||
| if (dom == null) { | ||
| isHydrating = false; |
Member
Author
There was a problem hiding this comment.
Might be cheaper to reuse the null assignment of line 313 and set isHydrating to null instead WDYT?
Member
There was a problem hiding this comment.
I think we could just move this to 312/314 without changing its type to null. Terser will be able to merge the statements better there.
developit
approved these changes
Apr 3, 2020
Member
developit
left a comment
There was a problem hiding this comment.
Fantastic. I have been using this modification locally, but it would have been be a bit before I would have been able to untangle it.
andrewiggins
approved these changes
Apr 3, 2020
Member
andrewiggins
left a comment
There was a problem hiding this comment.
LGTM! Love the new tests 🕺
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we see a newly inserted tree, we fallback to non-hydration mode for that specific subtree. This was brought up in a slack issue.
We'll have to introduce a
/debugwarning for this as well in a separate PR.