Fix error messages logged by failed prop type checks#2434
Merged
robertknight merged 2 commits intomasterfrom Apr 1, 2020
Merged
Fix error messages logged by failed prop type checks#2434robertknight merged 2 commits intomasterfrom
robertknight merged 2 commits intomasterfrom
Conversation
|
Size Change: +70 B (0%) Total Size: 38.7 kB
ℹ️ View Unchanged
|
robertknight
commented
Apr 1, 2020
robertknight
commented
Apr 1, 2020
| vnode.props, | ||
| getDisplayName(vnode), | ||
| serializeVNode(vnode) | ||
| 'prop', |
Member
Author
There was a problem hiding this comment.
TIL that "prop types" can also be used to check things that are not props, such as context. See https://github.com/facebook/prop-types/blob/1c4077b7455e037bd8f81f48e9c51d60c972f8e9/checkPropTypes.js#L37.
The error message logged when a value of an incorrect type is passed as the prop `propName` for a component `Widget` should read: ``` Failed prop type: Invalid prop `propName` supplied to `Widget` ``` Instead it read: ``` Failed Widget type: Invalid Widget `propName` supplied to `Widget` ```
f57298e to
a6016b6
Compare
JoviDeCroock
approved these changes
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error message logged when a value of an incorrect type is passed as
the prop
propNamefor a componentWidgetshould read:Instead it read:
The issue was that the wrong parameters were passed to
checkPropType.