Fix NoUpdate context#2420
Merged
JoviDeCroock merged 2 commits intomasterfrom Mar 17, 2020
Merged
Conversation
…props inside shouldComponentUpdate
|
Size Change: +3 B (0%) Total Size: 38.5 kB
ℹ️ View Unchanged
|
developit
approved these changes
Mar 17, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seemingly updated properties eagerly so I'm going to double check if we're not making any mistakes in the
componentinstance against this.Because we haven't called
Provideryet it seems to be working with a stale ref to theprops, this however is already correct onComponenthence whythis.propsprovides us with a correct result.Fixes: #2419