Skip to content

Skip setProperty for known bypass cases (key, children)#2213

Merged
marvinhagemeister merged 4 commits intomasterfrom
optimization-setproperty-stack-depth
Apr 1, 2020
Merged

Skip setProperty for known bypass cases (key, children)#2213
marvinhagemeister merged 4 commits intomasterfrom
optimization-setproperty-stack-depth

Conversation

@developit
Copy link
Copy Markdown
Member

This should reduce average stack depth and improve performance.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 27, 2019

Coverage Status

Coverage remained the same at 99.8% when pulling d6bfa62 on optimization-setproperty-stack-depth into f6577c4 on master.

Copy link
Copy Markdown
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@marvinhagemeister
Copy link
Copy Markdown
Member

@developit is this ready to merge or are there further things you'd like to play with?

Copy link
Copy Markdown
Member

@cristianbote cristianbote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Copy Markdown

Size Change: +6 B (0%)

Total Size: 38.7 kB

Filename Size Change
dist/preact.js 3.72 kB +1 B
dist/preact.min.js 3.72 kB +1 B
dist/preact.module.js 3.73 kB +3 B (0%)
dist/preact.umd.js 3.79 kB +1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.12 kB 0 B
compat/dist/compat.module.js 3.14 kB 0 B
compat/dist/compat.umd.js 3.17 kB 0 B
debug/dist/debug.js 2.98 kB 0 B
debug/dist/debug.module.js 2.96 kB 0 B
debug/dist/debug.umd.js 3.04 kB 0 B
devtools/dist/devtools.js 175 B 0 B
devtools/dist/devtools.module.js 185 B 0 B
devtools/dist/devtools.umd.js 252 B 0 B
hooks/dist/hooks.js 1.05 kB 0 B
hooks/dist/hooks.module.js 1.08 kB 0 B
hooks/dist/hooks.umd.js 1.12 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister marked this pull request as ready for review April 1, 2020 07:26
@marvinhagemeister marvinhagemeister merged commit 6a9f74c into master Apr 1, 2020
@marvinhagemeister marvinhagemeister deleted the optimization-setproperty-stack-depth branch April 1, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants