use node.error for CSS relevant errors#540
Merged
romainmenke merged 2 commits intomasterfrom Aug 1, 2023
Merged
Conversation
romainmenke
commented
Jul 23, 2023
| `Failed to find '${id}' | ||
| in [ | ||
| ${paths.join(",\n ")} | ||
| ${paths.join(",\n ")} |
Collaborator
Author
There was a problem hiding this comment.
Indent before :
message: `postcss-import: <css input>:3:1: Failed to find 'layer\`\`\`.css'␊
in [␊
/projects/postcss-import,␊
/projects/postcss-import/test/fixtures/imports␊
]`,
Indent now :
message: `postcss-import: <css input>:3:1: Failed to find 'layer\`\`\`.css'␊
in [␊
/projects/postcss-import,␊
/projects/postcss-import/test/fixtures/imports␊
]`,
RyanZim
reviewed
Aug 1, 2023
Collaborator
RyanZim
left a comment
There was a problem hiding this comment.
Don't need /s flag in new test regexes
Co-authored-by: Ryan Zimmerman <opensrc@ryanzim.com>
RyanZim
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #518
I've kept the
new Error()when checking plugin options.I don't think these are CSS syntax errors : https://github.com/postcss/postcss/blob/main/docs/guidelines/plugin.md#41-use-nodeerror-on-css-relevant-errors