Skip to content

feat: extract name from license file#7530

Merged
zkochan merged 8 commits intopnpm:mainfrom
btea:feat/extract-license-name
Jan 26, 2024
Merged

feat: extract name from license file#7530
zkochan merged 8 commits intopnpm:mainfrom
btea:feat/extract-license-name

Conversation

@btea
Copy link
Copy Markdown
Member

@btea btea commented Jan 17, 2024

In some cases, the license field may not exist in package.json but the license file does exist. Perhaps we can try to extract the license name from the file.

@btea btea requested a review from zkochan as a code owner January 17, 2024 03:09
Comment thread reviewing/license-scanner/src/getPkgInfo.ts Outdated
Co-authored-by: Zoltan Kochan <z@kochan.io>
Comment thread reviewing/license-scanner/src/getPkgInfo.ts Fixed
Comment thread reviewing/license-scanner/src/getPkgInfo.ts Fixed
@zkochan zkochan requested a review from weyert January 18, 2024 10:00
Comment thread reviewing/license-scanner/src/getPkgInfo.ts
Comment thread reviewing/license-scanner/src/getPkgInfo.ts
@zkochan zkochan merged commit 10a0896 into pnpm:main Jan 26, 2024
zkochan pushed a commit that referenced this pull request Jan 26, 2024
@btea btea deleted the feat/extract-license-name branch January 27, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants