feat: clear error on invalid node version#6916
Merged
Conversation
zkochan
reviewed
Aug 7, 2023
zkochan
reviewed
Aug 7, 2023
zkochan
approved these changes
Aug 7, 2023
Member
|
The tests have failed. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
@zkochan I have tested each case to see which one return 404. Any case that return 404 is invalid. All invalid cases should cause an error in the latest commit. |
Contributor
Author
|
@zkochan So the CI errors was caused by |
Member
|
|
Contributor
Author
|
I have separated the parser for |
zkochan
approved these changes
Aug 9, 2023
KSXGitHub
added a commit
to pnpm/pnpm.io
that referenced
this pull request
Aug 10, 2023
related change: pnpm/pnpm#6916
zkochan
pushed a commit
to pnpm/pnpm.io
that referenced
this pull request
Aug 10, 2023
related change: pnpm/pnpm#6916
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #6909