Skip to content

Make the FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE error and hint messages more clear#6304

Merged
zkochan merged 6 commits intopnpm:mainfrom
Daniel-Khodabakhsh:patch-1
Mar 29, 2023
Merged

Make the FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE error and hint messages more clear#6304
zkochan merged 6 commits intopnpm:mainfrom
Daniel-Khodabakhsh:patch-1

Conversation

@Daniel-Khodabakhsh
Copy link
Copy Markdown
Contributor

The current error and hint messages for FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE is not very straightforward in explaining what the issue is.

This PR attempt to fix this by being a bit more explicit as to what the required upgrade is (lockfile version incompatibility).

The original message was too confusing as per this post last year: https://github.com/orgs/pnpm/discussions/4847

@welcome
Copy link
Copy Markdown

welcome Bot commented Mar 28, 2023

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

Comment thread pkg-manager/core/src/install/index.ts Outdated
@zkochan zkochan merged commit e87754d into pnpm:main Mar 29, 2023
@welcome
Copy link
Copy Markdown

welcome Bot commented Mar 29, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@louiss0
Copy link
Copy Markdown

louiss0 commented May 7, 2023

There need to be better errors. I'm not just looking for workspace is out of sync but how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants