Make rule errors a little bit more DRY#3035
Merged
ondrejmirtes merged 1 commit intophpstan:1.11.xfrom May 1, 2024
axlon:dry-rule-errors
Merged
Make rule errors a little bit more DRY#3035ondrejmirtes merged 1 commit intophpstan:1.11.xfrom axlon:dry-rule-errors
ondrejmirtes merged 1 commit intophpstan:1.11.xfrom
axlon:dry-rule-errors
Conversation
Member
|
Thank you! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this message is used a lot throughout the codebase, and it could probably use a bit of DRYness, this would make it easier to change the message down the line it ever became necessary.
Additionally, this also makes it easier for PHPStan extensions' rules to use the exact same tip as PHPStan itself, if they do respect this setting being on or off