Skip to content

Fix result-cache with phpstan-types on New_ references#2894

Merged
ondrejmirtes merged 5 commits intophpstan:1.10.xfrom
staabm:fix-cache
Jan 30, 2024
Merged

Fix result-cache with phpstan-types on New_ references#2894
ondrejmirtes merged 5 commits intophpstan:1.10.xfrom
staabm:fix-cache

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Jan 30, 2024

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jan 30, 2024

I think the fix is not correct, as we have the same problem in more places. let me just have another look

refactored with 45307b9 so the fix also works for phpstan-types referenced via Catch_, Instanceof_ or similar references

@staabm staabm marked this pull request as ready for review January 30, 2024 15:36
@phpstan-bot
Copy link
Copy Markdown
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit ea52b59 into phpstan:1.10.x Jan 30, 2024
@staabm staabm deleted the fix-cache branch January 30, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants