Remove line from "nikic/php-parser" error message#2845
Merged
ondrejmirtes merged 3 commits intophpstan:1.10.xfrom Apr 22, 2024
Merged
Remove line from "nikic/php-parser" error message#2845ondrejmirtes merged 3 commits intophpstan:1.10.xfrom
ondrejmirtes merged 3 commits intophpstan:1.10.xfrom
Conversation
Contributor
Author
|
Please advise where can I put https://phpstan.org/r/11e0c7af-bd52-4add-8de0-98397c5d492e test and on what test can I base it - I need to assert the phpstan error message. |
Member
|
AnalyserIntegrationTest |
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Jan 2, 2024
4468bec to
fa7c4c5
Compare
73c1127 to
084ca63
Compare
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related discussion/issue: phpstan/phpstan#10358 (comment)