MethodExtensions class-name is case-insensitive#2562
Merged
ondrejmirtes merged 3 commits intophpstan:1.10.xfrom Aug 5, 2023
Merged
MethodExtensions class-name is case-insensitive#2562ondrejmirtes merged 3 commits intophpstan:1.10.xfrom
ondrejmirtes merged 3 commits intophpstan:1.10.xfrom
Conversation
Collaborator
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
staabm
commented
Aug 3, 2023
Contributor
Author
There was a problem hiding this comment.
there was no exisiting bug to fix for the throw-type-extension case.. but adding test coverage can not hurt
tests DynamicMethodThrowTypeExtension
| $returnType = $closure->call($newThis, new class {}); | ||
| assertType('true', $returnType); | ||
|
|
||
| $staticallyBoundClosureCaseInsensitive = \closure::bind($closure, $newThis); |
Contributor
Author
There was a problem hiding this comment.
test DynamicStaticMethodReturnTypeExtension
|
|
||
| public function dateTimeZoneDoesNotThrowCaseInsensitive(): void | ||
| { | ||
| new \DaTetImezOnE('UTC'); |
Contributor
Author
There was a problem hiding this comment.
test DynamicStaticMethodThrowTypeExtension
| { | ||
| $xml = new \SimpleXmlElement(''); | ||
| $elements = $xml->xpath('//data'); | ||
| assertType('array<SimpleXmlElement>', $elements); |
Contributor
Author
There was a problem hiding this comment.
test DynamicMethodReturnTypeExtension-case
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#9714 (comment)