Skip to content

Solve issue 8917 with array_column#2244

Merged
ondrejmirtes merged 1 commit intophpstan:1.10.xfrom
VincentLanglet:bug8917
Feb 25, 2023
Merged

Solve issue 8917 with array_column#2244
ondrejmirtes merged 1 commit intophpstan:1.10.xfrom
VincentLanglet:bug8917

Conversation

@VincentLanglet
Copy link
Copy Markdown
Contributor

@herndlm
Copy link
Copy Markdown
Contributor

herndlm commented Feb 19, 2023

Phew, the array column extension also looks multiple times more complicated than I thought it would 😅

@VincentLanglet
Copy link
Copy Markdown
Contributor Author

Phew, the array column extension also looks multiple times more complicated than I thought it would 😅

And the extension could be improve for a better optional keys support like
https://phpstan.org/r/ec725950-6493-4079-979f-9b753f93985f

But that's another issue.

@VincentLanglet VincentLanglet changed the base branch from 1.9.x to 1.10.x February 21, 2023 17:40
@ondrejmirtes ondrejmirtes merged commit e5a8507 into phpstan:1.10.x Feb 25, 2023
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

array_column() returns array{*NEVER*} instead of array{}

3 participants