Check if SymfonyHttplug actually implements HttpClient#253
Merged
dbu merged 2 commits intophp-http:1.xfrom Nov 30, 2023
Merged
Conversation
| return defined('GuzzleHttp\ClientInterface::MAJOR_VERSION'); | ||
| } | ||
|
|
||
| public static function isSymfonyImplementingHttpClient() |
Collaborator
There was a problem hiding this comment.
Suggested change
| public static function isSymfonyImplementingHttpClient() | |
| public static function isSymfonyImplementingHttplug() |
Contributor
Author
There was a problem hiding this comment.
HttpAsyncClient is kinda Httplug too
Contributor
There was a problem hiding this comment.
i agree with @arokettu
its not going to be relevant forever, we deprecated the synchronous php-http HttpClient interface in favor of the PSR18 http client. only the async php-http client is still relevant. when we do a new major of discovery, we will drop discovering HttpClient.
Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When looking for HttpClient, check if SymfonyHttplug actually implements HttpClient.
Why?
In Symfony 7, SymfonyHttplug no longer implements HttpClient
Checklist