Merged
Conversation
wwilsman
commented
Aug 12, 2021
| async close() { | ||
| if (!this.browser) return; | ||
|
|
||
| this.log.debug('Page closing', this.meta); |
Contributor
Author
There was a problem hiding this comment.
I also moved this from the close handler since the handler will be called on every automatically created page while this method is only called when intentionally closing a page. Having it remain in the former location would show several close logs in a row for pages with many frames.
This value is too low for CI and some assets are missed
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Bumps [@percy/sdk-utils](https://github.com/percy/cli/tree/HEAD/packages/sdk-utils) from 1.0.5 to 1.0.8. - [Release notes](https://github.com/percy/cli/releases) - [Commits](https://github.com/percy/cli/commits/v1.0.8/packages/sdk-utils) --- updated-dependencies: - dependency-name: "@percy/sdk-utils" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Thanks to #490, it now makes it possible to properly capture resources from isolated pages. However, during the network idle check, only the top-level network method is used which only references its own requests. This PR adds tracking isolated pages to the parent page to create a inverse relationship. And also adds a new network method to retrieve all nested page requests during the idle check. These changes make it so network idle will check for nested requests in addition to its own requests.
While here, I also came across a familiar race condition in the page constructor as a result of the page closing during an async call within the constructor. This same race condition exists in the network constructor, however with a check to prevent intentional page closed errors from bubbling. Rather than repeat the pattern, it was improved slightly to make debug logs less confusing. Now, when one of these async constructor calls happen with the page closing, the error is disregarded. All other errors will be logged rather than let bubble since an error from these locations usually stems from an error elsewhere.