Merged
Conversation
When requests are handled or forgotten, they should be removed from all trackers. Intercepted request mapping was updated to track the entire request event. During pending requests, already intercepted requests are always handled. During request interception, already pending requests are only handled when said request is actually the same request and not a redirect request. During request handling, redirects clean up other existing trackers besides auths.
Robdel12
approved these changes
Aug 2, 2021
Contributor
Robdel12
left a comment
There was a problem hiding this comment.
🏁 This was a reallly good find!
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
* ⬆️ Bump @percy/core from 1.0.0-beta.75 to 1.0.0-beta.76 Bumps [@percy/core](https://github.com/percy/cli/tree/HEAD/packages/core) from 1.0.0-beta.75 to 1.0.0-beta.76. - [Release notes](https://github.com/percy/cli/releases) - [Commits](https://github.com/percy/cli/commits/v1.0.0-beta.76/packages/core) --- updated-dependencies: - dependency-name: "@percy/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * ⬆️ Bump @percy/sdk-utils from 1.0.0-beta.75 to 1.0.0-beta.76 (#469) Bumps [@percy/sdk-utils](https://github.com/percy/cli/tree/HEAD/packages/sdk-utils) from 1.0.0-beta.75 to 1.0.0-beta.76. - [Release notes](https://github.com/percy/cli/releases) - [Commits](https://github.com/percy/cli/commits/v1.0.0-beta.76/packages/sdk-utils) --- updated-dependencies: - dependency-name: "@percy/sdk-utils" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
With network tracking, there are a number of events which need to be handled to manage requests properly. While some of these events are intended to happen in a specific order, and handlers are written in a way to handle an unexpected order of events, there aren't actually guards in place to prevent handling seemingly duplicate events.
The changes in this PR were found in Puppeteer after discovering a font-related issue. We have a history of font-related issues, so I thought to give these changes a try here. The specific issue that prompted these safeguards are a result of this Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1196004
Our network handling isn't an exact 1:1 of Puppeteer's, so I wasn't able to reproduce the issue with a test for the same. One likely reason is because we always have browser caches disabled because we have our own cache. Regardless, after breaking down the changes I decided they would be a good addition to have anyway.