✨ Refactor static snapshot logic into utils#465
Merged
Conversation
This not only cleans up the main snapshot command class and makes it easier to distinguish between different functionalities, but it also allows us to use these utils for other purposes, such as for static site generator SDKs (currently gatsby, could be more).
02403b1 to
5fd3ac8
Compare
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Bumps [@percy/core](https://github.com/percy/cli/tree/HEAD/packages/core) from 1.0.0-beta.74 to 1.0.0-beta.75. - [Release notes](https://github.com/percy/cli/releases) - [Commits](https://github.com/percy/cli/commits/v1.0.0-beta.75/packages/core) --- updated-dependencies: - dependency-name: "@percy/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This not only cleans up the main snapshot command class and makes it easier to distinguish between different functionalities, but it also allows us to use these utils for other purposes, such as for static site generator SDKs (currently gatsby, could be more in the future).
For the most part, this PR just moves some stuff around. The
withDefaultsandservemethods are now utils, and the path-page mapping was moved into it's own util. Smaller changes were made to replacethisreferences with config arguments.