✨ Allow registering multiple config migrations at a time#456
Merged
✨ Allow registering multiple config migrations at a time#456
Conversation
Instead, a default config migration can be registered to accomplish the same. Migrations are now registered in reverse order, a.k.a. last-in-first-out. This allows the default migration to always run last.
Robdel12
approved these changes
Jul 29, 2021
Contributor
Robdel12
left a comment
There was a problem hiding this comment.
🏁 oh this is a nice win!
We want to show this warning anytime the migration detects them. A deprecation log will only show once per message. This was the previous behaviour, but accidentally got dropped when it was moved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
With #450, the migrate function was updated to be able to migrate specific schemas. We can now utilize that new feature to register a snapshot config migration for deprecated options. These deprecations previously lived within a merge callback.
The migrate function was updated again in this PR to accept multiple migration at once similar to how we can register multiple schemas at once. The forced version was also moved into a default migration; and to ensure it always runs last, migrations are now registered in reverse order, so they run last-in-first-out.