✨ Add upload option to strip file extensions#434
Merged
Conversation
| import pkg from '../../package.json'; | ||
|
|
||
| const ALLOWED_FILE_TYPES = /\.(png|jpg|jpeg)$/i; | ||
| const ALLOWED_FILE_TYPES = /^\.(png|jpg|jpeg)$/i; |
There was a problem hiding this comment.
@wwilsman Should this also include uppercase for windows users where windows defaults the file type extension to upper case.
Contributor
Author
There was a problem hiding this comment.
@andressalinero no need, as the i at the end of the regular expression means it's case insensitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This implements and resolves #412 with a new
--strip-extensionsflag and accompanying config file option.The upload config options spreading was growing, so was adjusted to reference the config object rather than spread each individual config option.
The extensions are removed from file paths by parsing the path and rejoining without the extension. While doing this, I realized that the
nameparameter does not include parent directories and updated the resource helper accordingly.The allowed file type regular expression was also updated since it now tests the file extension only and not the entire path.