✨ Add queue concurrency to the upload command#419
Merged
Conversation
Robdel12
approved these changes
Jul 15, 2021
Contributor
Robdel12
left a comment
There was a problem hiding this comment.
🏁 I'll never stop loving all of the wins we get from consolidating the SDKs onto this toolchain.
(nice to see you get bit by the linter too sometimes HAHAHA)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This resolves #391 and utilizes core's queue class to parallelize the upload command. It adds a
upload.concurrencyoption as well to allow control of the queue size. It also borrows a pattern from core by waiting on uploads at the "end" of the process and clearing the queue on error to allow the process to continue.