Conversation
Robdel12
approved these changes
Jun 23, 2021
Contributor
Robdel12
left a comment
There was a problem hiding this comment.
🏁 Solid find after some dog pile debugging 😆
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Bumps [eslint](https://github.com/eslint/eslint) from 7.31.0 to 7.32.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.31.0...v7.32.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
In asset discovery when the cache is disabled, it doesn't matter if the
getResourceoption returns an existing resource. The existing resource will always be overridden with new response. However, root resources aren't normally included with other resources. So when a root resource requests itself (such as a canonical link) and cache is disabled, a new resource is created for the root response (butis-rootis not set since it happens during normal discovery). Later, when the root resource is added to the discovered resources, it ends up in the list of resources twice.Fixing this is pretty straight forward. We just need to always skip capturing the root resource, even if the cache is disabled.
Fixes #388