Merged
Conversation
Resource URLs should include the root origin, otherwise our infrastructure proxy fails to properly proxy the request over secure connections. This behavior is likely due to a default origin somewhere being http attempting to validate against https
Robdel12
approved these changes
Jun 22, 2021
Contributor
Robdel12
left a comment
There was a problem hiding this comment.
🏁 while I’m happy we no longer have a full suite of only E2E tests on Percy, I think this might be a good argument for a few smokes
Contributor
Author
|
I've always wanted to consolidate our old e2e tests into a single example app at the top level of this repo. Just hasn't been a huge priority since we have 100% test coverage otherwise |
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Bumps [@cypress/code-coverage](https://github.com/cypress-io/code-coverage) from 3.9.9 to 3.9.10. - [Release notes](https://github.com/cypress-io/code-coverage/releases) - [Commits](cypress-io/code-coverage@v3.9.9...v3.9.10) --- updated-dependencies: - dependency-name: "@cypress/code-coverage" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Resource URLs should include the root origin, otherwise our infrastructure proxy fails to properly proxy the request over secure connections. This behavior is likely due to a default origin somewhere being http attempting to validate against https.
This PR takes advantage of
new URL(input, base)behavior, where the origin of the second argument is used as the base of the input when the input is an absolute or relative pathname.